Check reference exists in commit.describe

Also fix test comment mismatch.

Author: jpichon

git_wrapper/commit.py

@@ -19,6 +19,7 @@ def __init__(self, git_repo, logger):
         self.git_repo = git_repo
         self.logger = logger
 
+    @reference_exists('sha')
     def describe(self, sha):
         """Return tag and commit info for a given sha
 

integration_tests/test_commit.py

@@ -1,6 +1,16 @@
+import pytest
+
+from git_wrapper import exceptions
 from git_wrapper.repo import GitRepo
 
 
+def test_describe(repo_root):
+    repo = GitRepo(repo_root)
+
+    with pytest.raises(exceptions.ReferenceNotFoundException):
+        repo.commit.describe("doesntExist")
+
+
 def test_revert(repo_root):
     repo = GitRepo(repo_root)
     repo.git.checkout("0.1.0")

tests/test_commit.py

@@ -22,7 +22,8 @@ def test_describe_tag_and_patch(mock_repo):
 
     repo = GitRepo('./', mock_repo)
 
-    assert expected == repo.commit.describe('12345')
+    with patch('git.repo.fun.name_to_object'):
+        assert expected == repo.commit.describe('12345')
 
 
 def test_describe_tag_only(mock_repo):
@@ -37,7 +38,8 @@ def test_describe_tag_only(mock_repo):
 
     repo = GitRepo('./', mock_repo)
 
-    assert expected == repo.commit.describe('12345')
+    with patch('git.repo.fun.name_to_object'):
+        assert expected == repo.commit.describe('12345')
 
 
 def test_describe_empty(mock_repo):
@@ -52,7 +54,8 @@ def test_describe_empty(mock_repo):
 
     repo = GitRepo('./', mock_repo)
 
-    assert expected == repo.commit.describe('12345')
+    with patch('git.repo.fun.name_to_object'):
+        assert expected == repo.commit.describe('12345')
 
 
 def test_describe_sha_doesnt_exist(mock_repo):
@@ -62,10 +65,25 @@ def test_describe_sha_doesnt_exist(mock_repo):
     THEN a ReferenceNotFoundException is raised
     """
     repo = GitRepo('./', mock_repo)
+
+    with patch('git.repo.fun.name_to_object') as mock_name_to_object:
+        mock_name_to_object.side_effect = git.exc.BadName()
+        with pytest.raises(exceptions.ReferenceNotFoundException):
+            repo.commit.describe('doesntexist')
+
+
+def test_describe_sha_with_describe_failure(mock_repo):
+    """
+    GIVEN GitRepo initialized with a path and repo
+    WHEN git.describe fails
+    THEN a DescribeException is raised
+    """
+    repo = GitRepo('./', mock_repo)
     repo.git.describe.side_effect = git.CommandError('describe')
 
-    with pytest.raises(exceptions.DescribeException):
-        repo.commit.describe('12345')
+    with patch('git.repo.fun.name_to_object'):
+        with pytest.raises(exceptions.DescribeException):
+            repo.commit.describe('12345')
 
 
 def test_describe_with_lightweight_tags(mock_repo):
@@ -81,7 +99,8 @@ def test_describe_with_lightweight_tags(mock_repo):
 
     repo = GitRepo('./', mock_repo)
 
-    assert expected == repo.commit.describe('12345')
+    with patch('git.repo.fun.name_to_object'):
+        assert expected == repo.commit.describe('12345')
 
 
 def test_commit(mock_repo):