Merge branch 'master' of https://github.com/mlarocca/DataStructures

Author: mlarocca

JavaScript/src/bloom_filter/bloom_filter.js

@@ -26,7 +26,7 @@ const LN_2 = Math.log(2);
  * @private
  * @description
  * Read a bit from the internal storage.
- * 
+ *
  * @param {!Uint8Array} bitsArray An array containing all the bits for the filter, broken down by the byte.
  * @param {!Number} index The index of the bit we want to read.
  * @return {Number} 1 or 0, depending on the value set for that bit.
@@ -44,7 +44,7 @@ function readBit(bitsArray, index) {
  * @description
  * Stores a bit on the internal bits array.
  * We can only store 1s, so there is no need to pass the value to store.
- * 
+ *
  * @param {!Uint8Array} bitsArray An array containing all the bits for the filter, broken down by the byte.
  * @param {!Number} index The index of the bit we want to write.
  * @return {!boolean} true iff at least one bit was flipped, false otherwise (meaning the key was already stored in the
@@ -140,8 +140,8 @@ class BloomFilter {
    *          tolerance would be too big to allocate an array for it.
    */
   constructor(maxSize, maxTolerance = 0.01, seed = randomInt()) {
-    let maxS = parseInt(maxSize, 10);
-    let tol = parseFloat(maxTolerance, 10);
+    let maxS = parseInt(maxSize, 10); //lgtm [js/superfluous-trailing-arguments]
+    let tol = parseFloat(maxTolerance, 10); //lgtm [js/superfluous-trailing-arguments]
 
     if (Number.isNaN(maxS) || maxSize <= 0) {
       throw new TypeError(ERROR_MSG_BLOOM_FILTER_CONSTRUCTOR_MAX_SIZE(maxSize));

JavaScript/src/disjointset/disjointset.js

@@ -3,9 +3,7 @@ import { ERROR_MSG_INVALID_ARGUMENT } from '../common/errors.js';
 
 const ERROR_MSG_UNION_FIND_CONSTRUCTOR_ILLEGAL_ARGUMENT = (val) => `Illegal argument for DisjointSet constructor: ${val}`;
 const ERROR_MSG_UNION_FIND_CONSTRUCTOR_DUPLICATE_ELEMENT = (val) => `Duplicate element in initial set for DisjointSet constructor: ${val}`;
-const ERROR_MSG_FIND_ILLEGAL_ARGUMENT = (val) => `Illegal argument for method find: ${val}`;
 const ERROR_MSG_FIND_NOT_IN_SET = (val) => `Argument ${val} for method find does not belong to this set`;
-const ERROR_MSG_ADD_ELEMENT = (val) => `Illegal argument for method add: ${val}`;
 
 const _elements = new WeakMap();
 

JavaScript/src/disjointset/variants/disjointset_lists.js

@@ -4,7 +4,6 @@ import { ERROR_MSG_INVALID_ARGUMENT } from '../../common/errors.js';
 const ERROR_MSG_UNION_FIND_CONSTRUCTOR_ILLEGAL_ARGUMENT = (val) => `Illegal argument for UnionFindLists constructor: ${val}`;
 const ERROR_MSG_UNION_FIND_CONSTRUCTOR_DUPLICATE_ELEMENT = (val) => `Duplicate element in initial set for UnionFindLists constructor: ${val}`;
 const ERROR_MSG_FIND_NOT_IN_SET = (val) => `Argument ${val} for method find does not belong to this set`;
-const ERROR_MSG_ADD_ELEMENT = (val) => `Illegal argument for method add: ${val}`;
 
 const _partitionsMap = new WeakMap();
 
@@ -18,7 +17,7 @@ const _partitionsMap = new WeakMap();
  *
  * This class also support queries to find if two elements are in the same subset, through the disjoint method.
  * In addition a few utility methods to check the number of elements in the "universe" and to add new elements (as singleton subsets) are provided.
- * 
+ *
  * This implementation uses the simplest approach, with lists (Set) for the sets
  */
 class UnionFindLists {

JavaScript/src/kd_tree/kd_tree.js

@@ -291,14 +291,14 @@ class Node {
         _point.set(this, points[0]);
         _size.set(this, 1);
         //Children are leaves
-        _left.set(this, Node.Empty(dimensionality, depth + 1, this));
-        _right.set(this, Node.Empty(dimensionality, depth + 1, this));
+        _left.set(this, Node.Empty(dimensionality, depth + 1));
+        _right.set(this, Node.Empty(dimensionality, depth + 1));
         break;
       default:
         let [med, left, right] = median(points, Node.keyByDim(this.dim));
         _point.set(this, med);
-        _left.set(this, new Node(left, dimensionality, depth + 1, this));
-        _right.set(this, new Node(right, dimensionality, depth + 1, this));
+        _left.set(this, new Node(left, dimensionality, depth + 1));
+        _right.set(this, new Node(right, dimensionality, depth + 1));
         _size.set(this, 1 + _left.get(this).size + _right.get(this).size);
         break;
     }
@@ -502,8 +502,8 @@ class Node {
     let added = false;
     if (this.isEmpty()) {
       _point.set(this, point);
-      _left.set(this, Node.Empty(point.dimensionality, this.depth + 1, this));
-      _right.set(this, Node.Empty(point.dimensionality, this.depth + 1, this));
+      _left.set(this, Node.Empty(point.dimensionality, this.depth + 1));
+      _right.set(this, Node.Empty(point.dimensionality, this.depth + 1));
       _size.set(this, 1);
       added = true;
     } else if (!this.point.equals(point)) {

JavaScript/src/strings/global_alignment.js

@@ -129,7 +129,7 @@ class GlobalAlignment {
 
     const n = pattern.length + 1;
     const m = text.length + 1;
-    let prevCol = new Array(n);
+    let prevCol;
     let currentCol = new Array(n);
 
     for (let i = 0; i < n; i++) {

JavaScript/src/utils/hash.js

@@ -23,8 +23,6 @@ const ERROR_MSG_HASH_SEED = (fname, val) => `Illegal parameter for ${fname}: see
  * @throws {TypeError(ERROR_MSG_HASH_SEED)} If seed is not a Number.
  */
 export function murmurHash32(key, seed = 0) {
-  'use strict';
-
   if (typeof key !== 'string') {
     throw new TypeError(ERROR_MSG_HASH_KEY_TYPE('murmurHash32', key));
   }

Python/mlarocca/datastructures/huffman/huffman.py

@@ -1,5 +1,5 @@
 import collections
-from typing import Dict, List, Optional, Type
+from typing import Dict, List, Optional
 from mlarocca.datastructures.heap.dway_heap import DWayHeap
 
 

README.md

@@ -1,5 +1,9 @@
 # **Algorithms and Data Structures in Action**
 
+[![Total alerts](https://img.shields.io/lgtm/alerts/g/mlarocca/AlgorithmsAndDataStructuresInAction.svg?logo=lgtm&logoWidth=18)](https://lgtm.com/projects/g/mlarocca/AlgorithmsAndDataStructuresInAction/alerts/)
+[![Language grade: JavaScript](https://img.shields.io/lgtm/grade/javascript/g/mlarocca/AlgorithmsAndDataStructuresInAction.svg?logo=lgtm&logoWidth=18)](https://lgtm.com/projects/g/mlarocca/AlgorithmsAndDataStructuresInAction/context:javascript)
+[![Language grade: Python](https://img.shields.io/lgtm/grade/python/g/mlarocca/AlgorithmsAndDataStructuresInAction.svg?logo=lgtm&logoWidth=18)](https://lgtm.com/projects/g/mlarocca/AlgorithmsAndDataStructuresInAction/context:python)
+
 This repository contains a collections of data structures and algorithms from the Manning book _Algorithms and Data Structures in Action_
 
 You can buy the book on Manning's web site: