Skip to content

Unexport consts in hooks package #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sahidvelji opened this issue May 24, 2025 · 0 comments · Fixed by #372
Closed

Unexport consts in hooks package #368

sahidvelji opened this issue May 24, 2025 · 0 comments · Fixed by #372

Comments

@sahidvelji
Copy link
Contributor

sahidvelji commented May 24, 2025

Is there a good reason for exporting these constants? Either way, the identifiers should be camelCased or PascalCased, not SCREAMING_SNAKE_CASE.

DOMAIN_KEY = "domain"
PROVIDER_NAME_KEY = "provider_name"
FLAG_KEY_KEY = "flag_key"
DEFAULT_VALUE_KEY = "default_value"
EVALUATION_CONTEXT_KEY = "evaluation_context"
ERROR_MESSAGE_KEY = "error_message"
REASON_KEY = "reason"
VARIANT_KEY = "variant"
VALUE_KEY = "value"
STAGE_KEY = "stage"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant