Skip to content

Unnecessary error return value in NewLoggingHook #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sahidvelji opened this issue May 24, 2025 · 0 comments · Fixed by #372
Closed

Unnecessary error return value in NewLoggingHook #369

sahidvelji opened this issue May 24, 2025 · 0 comments · Fixed by #372

Comments

@sahidvelji
Copy link
Contributor

sahidvelji commented May 24, 2025 •
edited
Loading

This function never returns an error, yet has an error return value.

go-sdk/openfeature/hooks/logging_hook.go

Line 31 in 42e33ba

func NewLoggingHook(includeEvaluationContext bool) (*LoggingHook, error) {

The same applies to

go-sdk/openfeature/hooks/logging_hook.go

Line 36 in 42e33ba

func NewCustomLoggingHook(includeEvaluationContext bool, logger *slog.Logger) (*LoggingHook, error) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: simplify and improve logging hook sahidvelji/go-sdk
1 participant
@sahidvelji