You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I suggest removing NewLoggingHook and renaming NewCustomLoggingHook to NewLoggingHook. I don't see the need to have both, especially since it is very easy for a user that wants to use the default logger to provide it like so:
hooks.NewLoggingHook(true, slog.Default())
This is a breaking change but I believe hooks are still experimental.
Uh oh!
There was an error while loading. Please reload this page.
I suggest removing
NewLoggingHook
and renamingNewCustomLoggingHook
toNewLoggingHook
. I don't see the need to have both, especially since it is very easy for a user that wants to use the default logger to provide it like so:This is a breaking change but I believe hooks are still experimental.
go-sdk/openfeature/hooks/logging_hook.go
Line 31 in 42e33ba
go-sdk/openfeature/hooks/logging_hook.go
Line 36 in 42e33ba
The text was updated successfully, but these errors were encountered: