Skip to content

Remove NewLoggingHook #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sahidvelji opened this issue May 24, 2025 · 0 comments · Fixed by #372
Closed

Remove NewLoggingHook #370

sahidvelji opened this issue May 24, 2025 · 0 comments · Fixed by #372

Comments

@sahidvelji
Copy link
Contributor

sahidvelji commented May 24, 2025

I suggest removing NewLoggingHook and renaming NewCustomLoggingHook to NewLoggingHook. I don't see the need to have both, especially since it is very easy for a user that wants to use the default logger to provide it like so:

hooks.NewLoggingHook(true, slog.Default())

This is a breaking change but I believe hooks are still experimental.

func NewLoggingHook(includeEvaluationContext bool) (*LoggingHook, error) {

func NewCustomLoggingHook(includeEvaluationContext bool, logger *slog.Logger) (*LoggingHook, error) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant