Skip to content

Several optimizations #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 24 commits into from
Closed

Several optimizations #14

wants to merge 24 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 21, 2016

No description provided.

@adriweb adriweb changed the title Update fileio_lib.asm Several optimizations Apr 21, 2016
@ghost
Copy link
Author

ghost commented Apr 21, 2016

Beginning at line 164, this is off because the return value should be in HL. Please either put it back, or modify it so that HL is either 0 or 1 depending on the archive status. Thanks!

I did not care of HL because I noticed that just after each
call _CheckInRAM_ASM \.r
there's a pop hl
That's why I thought the old value of HL (either 0 or 1) was useless, and only the flag Z was important...
Jacobly explained me the importance of _IsArchived:
I now understand :)

The multiplication here is incorrect, by the way.
which line , please ?

@jacobly0 jacobly0 closed this Apr 21, 2016
@ghost ghost deleted the master-1 branch April 21, 2016 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants