-
Notifications
You must be signed in to change notification settings - Fork 2.3k
docs: add typescript examples #5605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs: add typescript examples #5605
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5605 +/- ##
==========================================
- Coverage 97.01% 96.98% -0.03%
==========================================
Files 30 30
Lines 3355 3355
Branches 1416 1416
==========================================
- Hits 3255 3254 -1
+ Misses 100 99 -1
- Partials 0 2 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Autogenerated Review notesBuild & CI Example component DX & maintenance Minor ⸻ Suggested follow-ups (non-blocking) |
I like the direction taken here, but a bit worried about the double cost for maintaining both JS and TS, can you look into options to reduce that maintenance? |
Okay, I will think about how I can improve it |
name: Pull Request
about: Create a pull request to improve this repository
title: "Add TypeScript Examples"
labels: "docs"
assignees: "Sergey Kazarinov"
Description
Problem
In some examples it is not obvious how to use TypeScript, which causes difficulties. Also, when using the library with TypeScript earlier, an error was found (already fixed) due to the lack of examples
Changes
In this PR I migrated the docs-site to TypeScript and added all existing examples with typing.
As an addition, I added tabs to switch the display of code from JS to TS
Screenshots
To reviewers
Contribution checklist