Skip to content

Floating components - sync code to articles #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2018
Merged

Conversation

slemmon
Copy link
Contributor

@slemmon slemmon commented Jan 31, 2018

Updated all three examples based on feedback

Updated all three examples based on feedback
import './App.css';

const style = {
height: '300px',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

px isn't required :)

Does it even work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Works as-is. But, works with just height: 300 too. *shrug - cool!
I sent up another commit that pulls off the px to show how that can be abbreviated when styled inline.

@mschwartz mschwartz merged commit 293c6f2 into master Jan 31, 2018
@mschwartz
Copy link
Contributor

Awesome

@mschwartz mschwartz deleted the floating-components-3 branch January 31, 2018 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants