Floating components - sync code to articles #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated all three examples based on feedback
mschwartz
reviewed
Jan 31, 2018
| import './App.css'; | ||
|
|
||
| const style = { | ||
| height: '300px', |
There was a problem hiding this comment.
px isn't required :)
Does it even work?
There was a problem hiding this comment.
Yeah. Works as-is. But, works with just height: 300 too. *shrug - cool!
I sent up another commit that pulls off the px to show how that can be abbreviated when styled inline.
|
Awesome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated all three examples based on feedback