HIVE-28909: Modify McolumnDescriptor definition in package.jdo to sup… #5804
+145
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port JDK17 + JDO6.0 For Hive to support JDK17 + JDO6.0, select/update/delete queries of the table are failing to fetch column information of the table. The DataNucleus6.0 is unable to map the Mcolumn Descriptor definition to the underlying table schema due to the presence of CLOB type field for the join condition in the package.jdo file. This patch addresses the issue by avoiding the CLOB column in the join condition.
saihemanth-cloudera
force-pushed
the
hive-28909
branch
from
bb52471 to
b968745
Compare
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
deniskuzZ
reviewed
May 7, 2025
standalone-metastore/metastore-server/src/main/resources/datanucleus-log4j.properties
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
May 7, 2025
...metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MColumnDescriptor.java
Outdated
Show resolved
Hide resolved
asf-ci-hive
added
tests pending
tests unstable
and removed
tests failed
tests pending
labels
asf-ci-hive
added
tests failed
tests pending
and removed
tests pending
tests failed
labels
|
deniskuzZ
reviewed
May 9, 2025
| } | ||
|
|
||
| public List<MFieldSchema> getCols() { | ||
| return cols; | ||
| List<MFieldSchema> schemas = new ArrayList<>(); | ||
| if (getColumns() != null) { |
There was a problem hiding this comment.
Wonder why we need the double-conversion? Why not store the List<MFieldSchema> cols passed through the constructor?
private List<MFieldSchema> cols;
private List<MColumn> fields;
deniskuzZ
reviewed
May 9, 2025
| public MColumnDescriptor(List<MFieldSchema> cols) { | ||
| this.cols = cols; | ||
| columns = new ArrayList<>(cols.size()); | ||
| for (MFieldSchema schema : cols) { |
There was a problem hiding this comment.
minor: why not use stream API?
this.fields = cols.stream().map(schema ->
new MColumn(schema.getName(), schema.getType(), schema.getComment())
.collect(Collectors.toList())
deniskuzZ
reviewed
May 9, 2025
| } | ||
| } | ||
|
|
||
| public List<MColumn> getColumns() { |
There was a problem hiding this comment.
Could we come up with a better naming to distinguish 2: getColumns() & getCols()?
keep getCols(), but rename getColumns() to getFields or similar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…port JDK17 + JDO6.0
For Hive to support JDK17 + JDO6.0, select/update/delete queries of the table are failing to fetch column information of the table. The DataNucleus6.0 is unable to map the Mcolumn Descriptor definition to the underlying table schema due to the presence of CLOB type field for the join condition in the package.jdo file. This patch addresses the issue by avoiding the CLOB column in the join condition.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?