feat: Annotate CRDs with Controller version #602
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| if len(args) != 1 { | ||
| return fmt.Errorf("please specify the service alias for the AWS service API to generate") | ||
| if len(args) < 1 { | ||
| return fmt.Errorf("please specify the service alias for the AWS service API to generate: controller") |
There was a problem hiding this comment.
Why add the post fix : controller
There was a problem hiding this comment.
just needed to see where the error is coming from..we have this exact error message in 3 different places.
Maybe it can be handled in a different PR
| @@ -57,6 +57,7 @@ type {{ .CRD.Kind }}Status struct { | |||
| // {{ .CRD.Kind }} is the Schema for the {{ .CRD.Plural }} API | |||
| // +kubebuilder:object:root=true | |||
| // +kubebuilder:subresource:status | |||
| // +kubebuilder:metadata:annotations="controller-version={{ .ReleaseVersion }}" | |||
There was a problem hiding this comment.
just leaving thoughts here: another way would've been to modify the release script instead, and leverage yq to inject the annotation. But i pref what you're doing here
There was a problem hiding this comment.
this might be the better approach..since we don't run make build-controller when we do releases, the latest release version may not be annotated..Maybe i should add a controller-gen command here as well
|
/test efs-controller-test |
|
@michaelhtm: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.