[FirebaseAI] Change request header to match other platforms #1252
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @a-maurice, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request changes the request header in two files, firebaseai/src/GenerativeModel.cs and firebaseai/src/LiveGenerativeModel.cs. The header x-goog-api-client is being updated from genai-csharp to gl-csharp to better align with other platforms. The version information is still included in the header.
Highlights
- Header Change: The
x-goog-api-clientrequest header is updated fromgenai-csharptogl-csharp. - Consistency: The change aims to align the C# client's request header with other platforms.
Changelog
- firebaseai/src/GenerativeModel.cs
- Changed the
x-goog-api-clientheader fromgenai-csharptogl-csharpon line 337.
- Changed the
- firebaseai/src/LiveGenerativeModel.cs
- Changed the
x-goog-api-clientheader fromgenai-csharptogl-csharpon line 94.
- Changed the
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A header's name,
A small change, gl for gen,
Platforms now aligned.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
a-maurice
changed the title
There was a problem hiding this comment.
Code Review
The pull request changes the request header from genai-csharp to gl-csharp to align with other platforms. The change seems straightforward and necessary for consistency.
Merge Readiness
The code change is a simple header update and appears safe to merge. I am unable to directly approve the pull request, and recommend that users have others review and approve this code before merging. There are no critical or high severity issues, so it can be merged after addressing the medium severity issue.
| @@ -334,7 +334,7 @@ private string GetURL() { | |||
| private async Task SetRequestHeaders(HttpRequestMessage request) { | |||
| request.Headers.Add("x-goog-api-key", _firebaseApp.Options.ApiKey); | |||
| string version = FirebaseInterops.GetVersionInfoSdkVersion(); | |||
| request.Headers.Add("x-goog-api-client", $"genai-csharp/{version}"); | |||
| request.Headers.Add("x-goog-api-client", $"gl-csharp/{version}"); | |||
There was a problem hiding this comment.
Consider adding a comment explaining why this change is being made. While the PR description provides context, a brief comment here can help future developers understand the reasoning without having to dig through commit history. This is especially useful if the change is not immediately obvious.
request.Headers.Add("x-goog-api-client", $"gl-csharp/{version}"); // Changed to gl-csharp to match other platforms| @@ -91,7 +91,7 @@ public async Task<LiveSession> ConnectAsync(CancellationToken cancellationToken | |||
|
|
|||
| // Set initial headers | |||
| string version = FirebaseInterops.GetVersionInfoSdkVersion(); | |||
| clientWebSocket.Options.SetRequestHeader("x-goog-api-client", $"genai-csharp/{version}"); | |||
| clientWebSocket.Options.SetRequestHeader("x-goog-api-client", $"gl-csharp/{version}"); | |||
There was a problem hiding this comment.
Similar to the change in GenerativeModel.cs, adding a comment here explaining the reason for the header change would be beneficial for maintainability.
clientWebSocket.Options.SetRequestHeader("x-goog-api-client", $"gl-csharp/{version}"); // Changed to gl-csharp to match other platforms
Description
Change the request header from genai-csharp to gl-csharp, to better match the other platforms.
Testing
Type of Change
Place an
xthe applicable box: