Update Windows runner in build_windows action to windows-latest (from windows-2019)

[jonsimantov]

Description

Provide details of the change, and generalize the change in the PR title above.

This is the only place that windows-2019 is hard coded; these machines are going away at the end of June.

---

Testing

Describe how you've tested these changes.

Succeeded here: https://github.com/firebase/firebase-unity-sdk/actions/runs/15452657745

---

Type of Change

Place an x the applicable box:

• Bug fix. Add the issue # below if applicable.
• New feature. A non-breaking change which adds functionality.
• Other, such as a build process or documentation change.

---

[gemini-code-assist]

Hello @jonsimantov, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

Hello, this is gemini-code-assist providing a summary of this pull request. The primary objective of this PR is to update the Windows build configuration to use the windows-latest GitHub Actions runner. This change is necessary because the windows-2019 runner, which was previously used, is scheduled for deprecation. As part of this update, the build script is also adjusted to target a newer version of Visual Studio that is available on the windows-latest environment.

Highlights

• Windows Runner Update: Migrate the Windows build process from the deprecated windows-2019 GitHub Actions runner to the current windows-latest runner.
• Visual Studio Version Update: Update the CMake generator argument in the build script to use 'Visual Studio 17 2022', aligning with the environment provided by the windows-latest runner.

Changelog

• scripts/build_scripts/build_zips.py
  • Updated the CMake generator argument on line 433 from '-G Visual Studio 16 2019' to '-G Visual Studio 17 2022'.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

Old runner fades away,
New Windows build takes its place,
Code compiles anew.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the CMake generator used for Windows builds from Visual Studio 2019 to Visual Studio 2022. This change aligns with the move to newer Windows runners (windows-latest) in the build infrastructure, which is necessary as older runners are being deprecated. The code change itself is minimal and directly addresses the stated objective.

Summary of Findings

• Testing Description Placeholder: The testing section in the pull request description contains a placeholder [replace this line]: # (Describe your testing in detail.). While this is a minor documentation issue (low severity), it's worth noting that a detailed description of how the change was tested (e.g., running the Windows build action with this change) would be beneficial for reviewers. Per the review settings, I have not added a direct comment on this low-severity issue.

Merge Readiness

The code change itself is straightforward and appears correct for its intended purpose of updating the build environment. No critical, high, or medium severity issues were found in the code changes. The pull request description includes a placeholder for testing details, which is a minor point. Based on the code review, the changes seem ready to be merged. Please ensure that the necessary testing (e.g., running the Windows build action) has been completed and passed before merging. As a reviewer, I am unable to directly approve the pull request; please have other reviewers approve this code before merging.