Skip to content

🐛 clusterctl: accept upper case version #12237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 5, 2025
Merged

🐛 clusterctl: accept upper case version #12237

merged 4 commits into from
Jun 5, 2025

Conversation

sivchari
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #12233

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 18, 2025
sbueringer
sbueringer reviewed May 19, 2025
View reviewed changes
@sbueringer sbueringer added the area/clusterctl Issues or PRs related to clusterctl label May 19, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label May 19, 2025
@sivchari sivchari force-pushed the fix-parse-provider-name branch from f47e05e to a1f2a73 Compare May 20, 2025 14:26
@fabriziopandini
Copy link
Member

lgtm pending changes to doc

@dmvolod
Copy link
Member

dmvolod commented May 22, 2025

/cherry-pick release-1.10

@k8s-infra-cherrypick-robot
Copy link

@dmvolod: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dmvolod
Copy link
Member

dmvolod commented May 22, 2025

/cherry-pick release-1.9

@k8s-infra-cherrypick-robot
Copy link

@dmvolod: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dmvolod
Copy link
Member

dmvolod commented May 22, 2025

/cherry-pick release-1.8

@k8s-infra-cherrypick-robot
Copy link

@dmvolod: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dmvolod
Copy link
Member

dmvolod commented May 22, 2025 •
edited
Loading

@sivchari could you please change PR title to the issue title or like parseProviderName automatically make the provider version lower case as it's a bit confusing with original case.

sivchari added 2 commits May 26, 2025 19:18
@sivchari
fix: parseProviderName
c506b69 
Signed-off-by: sivchari <shibuuuu5@gmail.com>
@sivchari
update the doc
93fe676 
Signed-off-by: sivchari <shibuuuu5@gmail.com>
@sivchari sivchari force-pushed the fix-parse-provider-name branch from a1f2a73 to 93fe676 Compare May 26, 2025 10:24
@sivchari
Copy link
Member Author

/retitle 🐛 clusterctl: accept upper case version

@k8s-ci-robot k8s-ci-robot changed the title 🐛 parseProviderName automatically make the provider name lower case 🐛 clusterctl: accept upper case version May 26, 2025
@chrischdi
Copy link
Member

Note: we won't do cherry-picks for release-1.8 as it is EOL

fabriziopandini
fabriziopandini reviewed May 29, 2025
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e3a6e8020a511b844a08f0e58c0e278aa5db6563

@sivchari
add condition for validateProvider
872a9c0 
Signed-off-by: sivchari <shibuuuu5@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2025
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 29, 2025
fabriziopandini
fabriziopandini reviewed May 29, 2025
View reviewed changes
@sivchari
fix review findings
091aef8 
Signed-off-by: sivchari <shibuuuu5@gmail.com>
@fabriziopandini fabriziopandini added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 30, 2025
@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e5811944f495cc982da8ad237e721cdc72039224

@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-main

@sbueringer
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2025
@k8s-ci-robot k8s-ci-robot merged commit e19b605 into kubernetes-sigs:main Jun 5, 2025
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone Jun 5, 2025
@k8s-infra-cherrypick-robot
Copy link

@dmvolod: new pull request created: #12321

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jun 5, 2025
Merged
@k8s-infra-cherrypick-robot
Copy link

@dmvolod: new pull request created: #12322

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jun 5, 2025
Merged
@k8s-infra-cherrypick-robot
Copy link

@dmvolod: new pull request created: #12323

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jun 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@Jont828 Jont828 Awaiting requested review from Jont828

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.

clusterctl: provider version gets lower case on client.Init()
7 participants
@sivchari @fabriziopandini @dmvolod @k8s-infra-cherrypick-robot @chrischdi @k8s-ci-robot @sbueringer