Remove scope from opIndex

[dkorpel]

Trying to unblock dlang/dmd#14236

These opIndex functions return _fun(this._iterator[index]); which can easily escape this, so best to let it be inferred based on template parameters.

[thewilsonator]

please remove the whitespace changes.

[9il]

That may be a breaking change.

[dkorpel]

please remove the whitespace changes.

My editor did them automatically. I removed them now.

[9il]

so best to let it be inferred based on template parameters

It isn't possible as far as I know. Walter didn't implement scope inference.

[dkorpel]

It isn't possible as far as I know. Walter didn't implement scope inference.

He did, though it's not very good admittedly

[9il]

The code at dlang/dmd#14236 (comment) looks good to me. What is wrong there?

[dkorpel]

The function is marked scope, but it returns this.p, so it should be return scope.

[dkorpel]

However, since opIndex is inside a templated struct here, it should be able to infer return scope on top of scope. I guess I'll try to fix that on dmd's side.

[9il]

However, since opIndex is inside a templated struct here, it should be able to infer return scope on top of scope. I guess I'll try to fix that on dmd's side.

Thank you!