Skip to content

perf_hooks: couple of perf hooks improvements #58209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

perf_hooks: couple of perf hooks improvements #58209

wants to merge 2 commits into from
+21 −2

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented May 7, 2025

  • Add uvMetricsInfo to the json output for PerformanceNodeTiming ... just looks like this was overlooked
  • Add fast api variation for loopIdleTime

@jasnell jasnell requested review from anonrig and aduh95 May 7, 2025 04:15
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/performance

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 7, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66668/

anonrig
anonrig reviewed May 7, 2025
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented May 7, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.12%. Comparing base (b21574d) to head (8c33455).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/node_perf.cc 55.55% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58209      +/-   ##
==========================================
- Coverage   90.13%   90.12%   -0.02%     
==========================================
  Files         629      629              
  Lines      186628   186637       +9     
  Branches    36632    36619      -13     
==========================================
- Hits       168218   168206      -12     
+ Misses      11219    11211       -8     
- Partials     7191     7220      +29
Files with missing lines Coverage Δ
lib/internal/perf/nodetiming.js 94.31% <100.00%> (+0.03%) ⬆️
src/node_external_reference.h 100.00% <ø> (ø)
src/node_perf.cc 85.24% <55.55%> (-1.20%) ⬇️

... and 42 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jasnell
src: add fast loop idle time variation
8c33455 
```
perf_hooks/bench-eventlooputil.js method='ELU_passed' n=1000000                 1.18 %       ±2.02% ±2.69% ±3.50%
perf_hooks/bench-eventlooputil.js method='ELU_simple' n=1000000        ***      7.29 %       ±1.84% ±2.45% ±3.19%
perf_hooks/bench-eventlooputil.js method='idleTime' n=1000000           **      4.20 %       ±2.97% ±3.96% ±5.15%
```
@jasnell jasnell force-pushed the jasnell/perf_hooks_fast_apis branch from a17ab54 to 8c33455 Compare May 7, 2025 15:58
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66690/

BridgeAR
BridgeAR reviewed May 7, 2025
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is LGTM, it would just be good to have some rests to verify the fast code working as expected.

mcollina
mcollina approved these changes May 9, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig left review comments

@BridgeAR BridgeAR BridgeAR left review comments

@mcollina mcollina mcollina approved these changes

@Qard Qard Qard approved these changes

@aduh95 aduh95 Awaiting requested review from aduh95

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jasnell @nodejs-github-bot @mcollina @Qard @anonrig @BridgeAR