Skip to content

chore: add golangci-lint config file #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 27, 2025

Conversation

sahidvelji
Copy link
Contributor

This PR

  • Add a golangci-lint config file. The linters configured here are the default ones that you see here: https://golangci-lint.run/usage/linters/. In addition to that, I've also enabled the gofmt formatter, which just ensures that code is formatted using go fmt.
  • Also introduce a new Makefile target fix, which auto-fixes some linter findings. See this table for linters which support auto-fix: https://golangci-lint.run/usage/linters/

Related Issues

Fixes #360

Notes

https://golangci-lint.run/usage/configuration/

Follow-up Tasks

How to test

Signed-off-by: Sahid Velji <sahidvelji@gmail.com>
Signed-off-by: Sahid Velji <sahidvelji@gmail.com>
Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.89%. Comparing base (42e33ba) to head (6c520cb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
+ Coverage   85.75%   85.89%   +0.13%     
==========================================
  Files          20       20              
  Lines        1453     1453              
==========================================
+ Hits         1246     1248       +2     
+ Misses        186      185       -1     
+ Partials       21       20       -1     
Flag Coverage Δ
e2e 85.89% <ø> (+0.13%) ⬆️
unit 85.89% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sahidvelji sahidvelji marked this pull request as ready for review May 22, 2025 20:07
@sahidvelji sahidvelji requested review from a team as code owners May 22, 2025 20:07
@aepfli aepfli merged commit 8844be4 into open-feature:main May 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a golangci-lint config file
3 participants