fix: add PCRE2 capability to standalone module #3377
+242
−162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theseion
requested changes
May 10, 2025
|
|
||
| pcre_fullinfo((const pcre *)preg->re_pcre, NULL, PCRE_INFO_CAPTURECOUNT, &nsub); | ||
| preg->re_nsub = nsub; | ||
| #endif // end of WITH_PCRE |
There was a problem hiding this comment.
Suggested change
| #endif // end of WITH_PCRE | |
| #endif |
There was a problem hiding this comment.
Instead of removing this comment, I should add a new comment to line 94:
#else // otherwise use PCRE
| #ifdef PCRE_ERROR_BADUTF8_OFFSET | ||
| case PCRE_ERROR_BADUTF8_OFFSET: return AP_REG_INVARG; | ||
| #endif | ||
| #endif // end of WITH_PCRE |
There was a problem hiding this comment.
Suggested change
| #endif // end of WITH_PCRE | |
| #endif |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
This PR adds
PCRE2related code tostandalonemodule.why
Previously if the user chose PCRE2 regex engine (with
--with-pcre2at build time), the standalone module did not handle that, and still wanted to be built with the old regex engine.Furthermore, the modules
make testworkflow also usesstandalonemodule too, and withPCRE2the whole test case was broken. This patch fixes that too.