-
-
Notifications
You must be signed in to change notification settings - Fork 652
perf: try add cache for hotpath function #10224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 Benchmark detail: Open
|
CodSpeed Performance ReportMerging #10224 will not alter performanceComparing Summary
|
fe41986
to
956fd58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stats.toJson()
test got about 7%
performance improvement. LGTM
956fd58
to
9ddac20
Compare
but it will have memory leak issue, since it never evict and I'm not sure whether it's a issue |
Summary
try add cache for hotpath function
Checklist