Skip to content

[Custom Amounts] Remove edit custom amount by percentage option #15709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

toupper
Copy link
Contributor

@toupper toupper commented Jun 4, 2025

Fixes WOOMOB-374

Description

This PR removes the option to edit Custom Amounts via percentage. Instead, we now show the custom amount editor directly, skipping the previous menu sheet.

The reason for this change is that editing the custom amount by percentage can be confusing under the current logic. Specifically, the base amount used for the calculation includes the custom amount itself — which likely doesn’t align with user expectations. We considered subtracting the custom amount from the base amount to resolve this, but that would introduce additional complexity (e.g. tax recalculations). That said, we’re open to implementing it in the future if we see user demand.

Additionally, I renamed a property and updated a comment to better reflect their purpose.

Steps to reproduce

  1. Go to Orders
  2. Tap on + to create a new order
  3. Add a product
  4. Add a custom amount via percentage
  5. Tap on the custom amount pencil button to edit the custom amount. See that, unlike when we were adding a custom amount, we're not offered now the option to edit it via percentage

Screenshots

Simulator.Screen.Recording.-.iPhone.16.-.2025-06-04.at.15.00.08.mp4

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@toupper toupper added this to the 22.6 milestone Jun 4, 2025
@toupper toupper requested review from joshheald and iamgabrielma June 4, 2025 13:06
@toupper toupper added the feature: order creation All tasks related to creating an order label Jun 4, 2025
@toupper toupper changed the title Issue/woomob 374 remove edit custom amount percentage [Custom Amounts] Remove edit custom amount by percentage option Jun 4, 2025
@wpmobilebot
Copy link
Collaborator

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Number30257
VersionPR #15709
Bundle IDcom.automattic.alpha.woocommerce
Commit2b09dfc
Installation URL7hrstv6nu1h7g
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

Copy link
Contributor

@joshheald joshheald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, thanks for sorting this 😊

/// Defines whether the new custom amount modal is presented.
@Published var showAddCustomAmount: Bool = false
/// Defines whether the custom amount modal is presented.
@Published var showCustomAmountView: Bool = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for renaming this 👍

@toupper toupper merged commit 53db7a4 into trunk Jun 5, 2025
18 of 19 checks passed
@toupper toupper deleted the issue/WOOMOB-374-remove-edit-custom-amount-percentage branch June 5, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: order creation All tasks related to creating an order
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants