[Custom Amounts] Remove edit custom amount by percentage option #15709
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes WOOMOB-374
Description
This PR removes the option to edit Custom Amounts via percentage. Instead, we now show the custom amount editor directly, skipping the previous menu sheet.
The reason for this change is that editing the custom amount by percentage can be confusing under the current logic. Specifically, the base amount used for the calculation includes the custom amount itself — which likely doesn’t align with user expectations. We considered subtracting the custom amount from the base amount to resolve this, but that would introduce additional complexity (e.g. tax recalculations). That said, we’re open to implementing it in the future if we see user demand.
Additionally, I renamed a property and updated a comment to better reflect their purpose.
Steps to reproduce
Screenshots
Simulator.Screen.Recording.-.iPhone.16.-.2025-06-04.at.15.00.08.mp4
RELEASE-NOTES.txt
if necessary.